My concern with the 'springed' pre-pump valve is giving away control of the normal, direct gravity feed to the pump, something sticking in there it's goodbye to the engine while riding... A manual valve with some stiff mechanism would very probably never shut off by itself (most likely error would be\is the owner forgetting to turn it to 'on', if no extra warning mechanism fitted).
And as mentioned above, if for any reason the pump drains empty (weak spring\ball in the crankcase), it would not be primed and may not manage to suck open the valve on the feed side. With tank return looking good for a while... ref. alanp's post.
But hey, just theoretical, those springed valves may be of excellent quality (they must be!), and work fine for dozens of years for all I know.